Re: [PATCH] add 'svn:use-commit-times' property
From: Masaru Tsuchiyama <m.tmatma_at_gmail.com>
Date: Thu, 08 Aug 2013 23:13:54 +0900
>> +/** The value to force the executable property to when set.
> Fix line breaks, wrap to 80 columns.
> Please make the comments say more than the struct member name does.
> Wrong indentation. The 'if' (including its block) should be two spaces
> "mutually exclusive"
>> + SVN_ERR_ASSERT( (fb->use_commit_times & fb->remove_use_commit_times) == 0 );
Fixed the logic.
>> + if ( !fb->adding_file )
>> " before it is modified. Makes the working copy file read-only¥n"
On Japanse version of Windows (SJIS), Yen and backslash are same symbol.
>> + 'svn:date', '2001-01-01T00:00:00.000000Z',
changed the date.
> Please add a trailing comma.
-- Masaru Tsuchiyama <m.tmatma_at_gmail.com>
This is an archived mail posted to the Subversion Dev mailing list.