[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add 'svn:use-commit-times' property

From: Masaru Tsuchiyama <m.tmatma_at_gmail.com>
Date: Thu, 08 Aug 2013 23:13:54 +0900

>> +/** The value to force the executable property to when set.
>> + *
>> + * @deprecated Provided for backward compatibility with the 1.4 API.
>> + * Use @c SVN_PROP_BOOLEAN_TRUE instead.

removed this.

> Fix line breaks, wrap to 80 columns.

fixed this.

> Please make the comments say more than the struct member name does.

added comments.

> Wrong indentation. The 'if' (including its block) should be two spaces
> fewer indented than it is.

fixed indentation.

> "mutually exclusive"

fixed.

>> + SVN_ERR_ASSERT( (fb->use_commit_times & fb->remove_use_commit_times) == 0 );
>
> Use boolean-and, not bitwise.

Fixed the logic.

>> + if ( !fb->adding_file )
>
> No whitespace between parentheses and condition.

Fixed.

>> " before it is modified. Makes the working copy file read-onlyn"
>> " when it is not locked. Use 'svn propdel svn:needs-lock PATH...'n"
>> " to clear.n"
>> + " svn:use-commit-times - If present, make the timestamp of the filen"
>> + " to commit time. Use 'svn propdel svn:use-commit-times PATH...' to clear.n"
>> "n"
>> " Subversion recognizes the following special versioned properties on an"
>> " directory:n"
>
> Encoding problem? I see a Yen symbol where a backslash should be.

On Japanse version of Windows (SJIS), Yen and backslash are same symbol.
What do you see in the attached file, not inline text?

>> + 'svn:date', '2001-01-01T00:00:00.000000Z',
>> + secs_svn_date = time.mktime( (2001, 1, 1, 0, 0, 0, 0, 0, 0) )
>
> Personally I wouldn't use all-zeroes as the test value, that's too
> likely to false negative the test (ie, pass when there's a problem).

changed the date.

> Please add a trailing comma.

Fixed.

-- 
Masaru Tsuchiyama <m.tmatma_at_gmail.com>

Received on 2013-08-08 16:14:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.