[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1302682 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h sb_bucket.c serf.c update.c util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 21 Mar 2012 17:55:41 -0400

On Wed, Mar 21, 2012 at 17:16, Daniel Shahaf <danielsh_at_elego.de> wrote:
> gstein_at_apache.org wrote on Mon, Mar 19, 2012 at 22:04:37 -0000:
>> +svn_ra_serf__copy_into_spillbuf(svn_spillbuf_t **spillbuf,
>> +                                serf_bucket_t *bkt,
>> +                                apr_pool_t *result_pool,
>> +                                apr_pool_t *scratch_pool)
>> +{
>> +      status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
>> +
>> +      /* ### we should throw an error, if the bucket does.  */
>> +      SVN_ERR_ASSERT(status == APR_SUCCESS || status == APR_EOF);
>
> Can we please avoid these in new code?

Why? I see no problem here: it will just bail out with an error. It is
the NO_RETURN() form that causes an abort() because it has nowhere
else to go.

Cheers,
-g
Received on 2012-03-21 22:56:12 CET

This is an archived mail posted to the Subversion Dev mailing list.