Re: svn commit: r1302682 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h sb_bucket.c serf.c update.c util.c

gstein_at_apache.org wrote on Mon, Mar 19, 2012 at 22:04:37 -0000:
> +svn_ra_serf__copy_into_spillbuf(svn_spillbuf_t **spillbuf,
> + serf_bucket_t *bkt,
> + apr_pool_t *result_pool,
> + apr_pool_t *scratch_pool)
> +{
> + status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
> +
> + /* ### we should throw an error, if the bucket does. */
> + SVN_ERR_ASSERT(status == APR_SUCCESS || status == APR_EOF);

Can we please avoid these in new code?
Received on 2012-03-21 22:17:42 CET