[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1302682 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h sb_bucket.c serf.c update.c util.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 22 Mar 2012 08:33:41 +0000 (GMT)

Greg Stein wrote:
> Daniel Shahaf wrote:
>> gstein_at_apache.org wrote:
>>> +svn_ra_serf__copy_into_spillbuf(svn_spillbuf_t **spillbuf,
>>> +                                serf_bucket_t *bkt,
>>> +                                apr_pool_t *result_pool,
>>> +                                apr_pool_t *scratch_pool)
>>> +{
>>> +      status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
>>> +
>>> +      /* ### we should throw an error, if the bucket does.  */
>>> +      SVN_ERR_ASSERT(status == APR_SUCCESS || status == APR_EOF);
>>
>> Can we please avoid these in new code?
>
> Why?

Hi Greg.  I'm puzzled by your response.  You wrote "### we should throw an error" -- and now you're asking Daniel why?

> I see no problem here: it will just bail out with an error.

Not true in general; only if the application writer explicitly sets the malfunction handler to do so.

Anyway, the point is not only about how the application exits, but about writing code that says what we mean.

- Julian
Received on 2012-03-22 09:34:18 CET

This is an archived mail posted to the Subversion Dev mailing list.