Re: svn commit: r40422 - trunk/subversion/libsvn_subr

2009-11-09 14:44:38 Greg Stein napisał(a):
> On Sun, Nov 8, 2009 at 16:29, Arfrever Frehtes Taifersar Arahesis
> <Arfrever.FTA_at_gmail.com> wrote:
> > Author: arfrever
> > Date: Sun Nov 8 13:29:36 2009
> > New Revision: 40422
> >
> > Log:
> > * subversion/libsvn_subr/dso.c
> > (svn_dso_load): Use fprintf() instead of SVN_DBG() to print error message.
> >
> > Modified:
> > trunk/subversion/libsvn_subr/dso.c
> >
> > Modified: trunk/subversion/libsvn_subr/dso.c
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/dso.c?pathrev=40422&r1=40421&r2=40422
> > ==============================================================================
> > --- trunk/subversion/libsvn_subr/dso.c Fri Nov 6 21:30:40 2009 (r40421)
> > +++ trunk/subversion/libsvn_subr/dso.c Sun Nov 8 13:29:36 2009 (r40422)
> > @@ -107,7 +107,7 @@ svn_dso_load(apr_dso_handle_t **dso, con
> > {
> > #ifdef SVN_DEBUG
> > char buf[1024];
> > - SVN_DBG(("%s\n", apr_dso_error(*dso, buf, 1024)));
> > + fprintf(stderr, "%s\n", apr_dso_error(*dso, buf, 1024));
> > #endif
> > *dso = NULL;
>
> Why did you revert my change?
>
> I used SVN_DBG() *specifically* so that we would get proper formatting
> of the error messages. You just broke that. Explain.

I didn't know that I was reverting anything. Last time I checked SVN_DBG was causing printing
of ugly "DBG" and was omitting names of directories, so e.g. SVN_DBG called in
subversion/libsvn_client/copy.c and subversion/libsvn_wc/copy.c would print filename "copy.c".

-- 
Arfrever Frehtes Taifersar Arahesis
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2417418