[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40422 - trunk/subversion/libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 9 Nov 2009 08:44:38 -0500

Why did you revert my change?

I used SVN_DBG() *specifically* so that we would get proper formatting
of the error messages. You just broke that. Explain.

-g

On Sun, Nov 8, 2009 at 16:29, Arfrever Frehtes Taifersar Arahesis
<Arfrever.FTA_at_gmail.com> wrote:
> Author: arfrever
> Date: Sun Nov  8 13:29:36 2009
> New Revision: 40422
>
> Log:
> * subversion/libsvn_subr/dso.c
>  (svn_dso_load): Use fprintf() instead of SVN_DBG() to print error message.
>
> Modified:
>   trunk/subversion/libsvn_subr/dso.c
>
> Modified: trunk/subversion/libsvn_subr/dso.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/dso.c?pathrev=40422&r1=40421&r2=40422
> ==============================================================================
> --- trunk/subversion/libsvn_subr/dso.c  Fri Nov  6 21:30:40 2009        (r40421)
> +++ trunk/subversion/libsvn_subr/dso.c  Sun Nov  8 13:29:36 2009        (r40422)
> @@ -107,7 +107,7 @@ svn_dso_load(apr_dso_handle_t **dso, con
>         {
>  #ifdef SVN_DEBUG
>           char buf[1024];
> -          SVN_DBG(("%s\n", apr_dso_error(*dso, buf, 1024)));
> +          fprintf(stderr, "%s\n", apr_dso_error(*dso, buf, 1024));
>  #endif
>           *dso = NULL;
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2415614
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415783
Received on 2009-11-09 14:44:50 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.