[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40422 - trunk/subversion/libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 13 Nov 2009 01:06:16 -0500

On Fri, Nov 13, 2009 at 00:32, Arfrever Frehtes Taifersar Arahesis
<arfrever.fta_at_gmail.com> wrote:
> 2009-11-09 14:44:38 Greg Stein napisał(a):
>> On Sun, Nov 8, 2009 at 16:29, Arfrever Frehtes Taifersar Arahesis
>> <Arfrever.FTA_at_gmail.com> wrote:
>> > Author: arfrever
>> > Date: Sun Nov  8 13:29:36 2009
>> > New Revision: 40422
>> >
>> > Log:
>> > * subversion/libsvn_subr/dso.c
>> >  (svn_dso_load): Use fprintf() instead of SVN_DBG() to print error message.
>> >
>> > Modified:
>> >   trunk/subversion/libsvn_subr/dso.c
>> >
>> > Modified: trunk/subversion/libsvn_subr/dso.c
>> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/dso.c?pathrev=40422&r1=40421&r2=40422
>> > ==============================================================================
>> > --- trunk/subversion/libsvn_subr/dso.c  Fri Nov  6 21:30:40 2009        (r40421)
>> > +++ trunk/subversion/libsvn_subr/dso.c  Sun Nov  8 13:29:36 2009        (r40422)
>> > @@ -107,7 +107,7 @@ svn_dso_load(apr_dso_handle_t **dso, con
>> >         {
>> >  #ifdef SVN_DEBUG
>> >           char buf[1024];
>> > -          SVN_DBG(("%s\n", apr_dso_error(*dso, buf, 1024)));
>> > +          fprintf(stderr, "%s\n", apr_dso_error(*dso, buf, 1024));
>> >  #endif
>> >           *dso = NULL;
>>
>> Why did you revert my change?
>>
>> I used SVN_DBG() *specifically* so that we would get proper formatting
>> of the error messages. You just broke that. Explain.
>
> I didn't know that I was reverting anything. Last time I checked SVN_DBG was causing printing
> of ugly "DBG" and was omitting names of directories, so e.g. SVN_DBG called in
> subversion/libsvn_client/copy.c and subversion/libsvn_wc/copy.c would print filename "copy.c".

That "ugly" DBG prefix allows the line to be filtered by our test suite.

And yes... it is a revert. i put the SVN_DBG in there a while back,
and you reverted that change. I'll get the SVN_DBG put back in, with
some additional comments for its presence.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2417427
Received on 2009-11-13 07:06:27 CET

This is an archived mail posted to the Subversion Dev mailing list.