[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40234 - trunk/subversion/mod_dav_svn

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Wed, 28 Oct 2009 13:52:40 +0530

Greg Stein wrote:
> On Tue, Oct 27, 2009 at 13:16, Senthil Kumaran S <senthil_at_collab.net> wrote:
>> ...
>> +++ trunk/subversion/mod_dav_svn/version.c Tue Oct 27 10:16:31 2009 (r40234)
>> @@ -1203,7 +1203,7 @@ dav_svn__build_lock_hash(apr_hash_t **lo
>> return derr;
>>
>> /* Create an absolute fs-path */
>> - lockpath = svn_path_join(path_prefix, cdata, pool);
>> + lockpath = svn_dirent_join(path_prefix, cdata, pool);
>
> If that is a repository path, then you shouldn't use a dirent
> function. iirc, you should be using uri_join. (it would be nice if FS
> paths were relpaths, but they tend to have a leading slash, so that
> leaves uri_join)

After looking at the surrounding code, I had an impression that an fs-path will
be a local filesystem directory and hence did the above. Will change it as per
your comments.

Thank you.

-- 
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411986
Received on 2009-10-28 09:23:18 CET

This is an archived mail posted to the Subversion Dev mailing list.