[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40234 - trunk/subversion/mod_dav_svn

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 28 Oct 2009 03:31:09 -0400

On Tue, Oct 27, 2009 at 13:16, Senthil Kumaran S <senthil_at_collab.net> wrote:
>...
> +++ trunk/subversion/mod_dav_svn/version.c      Tue Oct 27 10:16:31 2009        (r40234)
> @@ -1203,7 +1203,7 @@ dav_svn__build_lock_hash(apr_hash_t **lo
>                 return derr;
>
>               /* Create an absolute fs-path */
> -              lockpath = svn_path_join(path_prefix, cdata, pool);
> +              lockpath = svn_dirent_join(path_prefix, cdata, pool);

If that is a repository path, then you shouldn't use a dirent
function. iirc, you should be using uri_join. (it would be nice if FS
paths were relpaths, but they tend to have a leading slash, so that
leaves uri_join)

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411970
Received on 2009-10-28 08:31:35 CET

This is an archived mail posted to the Subversion Dev mailing list.