[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40234 - trunk/subversion/mod_dav_svn

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Wed, 28 Oct 2009 14:15:16 +0530

Hi Greg,

Senthil Kumaran S wrote:
>> If that is a repository path, then you shouldn't use a dirent
>> function. iirc, you should be using uri_join. (it would be nice if FS
>> paths were relpaths, but they tend to have a leading slash, so that
>> leaves uri_join)
>
> After looking at the surrounding code, I had an impression that an fs-path will
> be a local filesystem directory and hence did the above. Will change it as per
> your comments.

I got the rationale behind it by reading the doc string from 'svn_uri_join'
which says the following:

<snip>
 * If @a component starts with a '/' and @a base contains a scheme, the

 * scheme defined joining rules are applied.
</snip>

Done in r40243.

-- 
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411994
Received on 2009-10-28 09:45:56 CET

This is an archived mail posted to the Subversion Dev mailing list.