[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34214 - in trunk/subversion: include libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 14 Nov 2008 22:49:09 -0800

On Fri, Nov 14, 2008 at 7:40 PM, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> Neels J. Hofmeyr wrote:
>> Stefan Sperling wrote:
>>> On Fri, Nov 14, 2008 at 06:19:27PM -0800, neels_at_tigris.org wrote:
>>>> Author: neels
>>>> Date: Fri Nov 14 18:19:27 2008
>>>> New Revision: 34214
>>>> Log:
>>>> Follow up on r34178, getting rid of compiler warnings.

Ah! Thanks!

>>>> * subversion/include/svn_string.h,
>>>> * subversion/libsvn_subr/svn_string.c
>>>> (svn_cstring_join): Make first parameter STRINGS const.
>>> Hmmm... can already released public API be changed like that?


>> We don't want a svn_cstring_join2(), do we?
>> Instead, we could cast explicitly to remove the warnings from gstein's r34178.

No need. This is a valid change. From a developer's standpoint, they
can now pass either non-const (as before) or const arrays into
svn_cstring_join(). We're *adding* capability, but not taking away (or
making source incompatible) anything they had before. At a binary
level, nothing has changed either. We're simply telling developers
"hey, we won't change what you pass to us."

Totally safe change.

*Removing* const is a no-no, however.

> Then bug Greg about it and let him fix it. :P
>> But to me the committed fix feels right. svn_cstring_join() doesn't ever
>> change that parameter. Does making the arg const even cause warnings in
>> calling code? It doesn't, does it?
> I seem to recall us changing the constness of existing function parameters
> before, but I don't remember whether we were making them const or removing it.
> I seem to think the latter, which feels better for API compatibility, but I
> don't recall for certain.

Adding const is fine, removing is Bad.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-15 07:49:24 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.