[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34214 - in trunk/subversion: include libsvn_subr

From: Branko Čibej <brane_at_xbc.nu>
Date: Sat, 15 Nov 2008 11:17:43 +0100

Greg Stein wrote:
>> ...
>>> We don't want a svn_cstring_join2(), do we?
>>> Instead, we could cast explicitly to remove the warnings from gstein's r34178.
> No need. This is a valid change. From a developer's standpoint, they
> can now pass either non-const (as before) or const arrays into
> svn_cstring_join(). We're *adding* capability, but not taking away (or
> making source incompatible) anything they had before. At a binary
> level, nothing has changed either. We're simply telling developers
> "hey, we won't change what you pass to us."
> Totally safe change.

So I'd have thought. But I recall at least once when this came up,
someone argued that adding const is potentially an ABI change on some
architectures that may pass const arguments differently.

So which is it?

-- Brane

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-15 11:18:00 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.