[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34214 - in trunk/subversion: include libsvn_subr

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 14 Nov 2008 21:40:43 -0600

Neels J. Hofmeyr wrote:
> Stefan Sperling wrote:
>> On Fri, Nov 14, 2008 at 06:19:27PM -0800, neels_at_tigris.org wrote:
>>> Author: neels
>>> Date: Fri Nov 14 18:19:27 2008
>>> New Revision: 34214
>>> Log:
>>> Follow up on r34178, getting rid of compiler warnings.
>>> * subversion/include/svn_string.h,
>>> * subversion/libsvn_subr/svn_string.c
>>> (svn_cstring_join): Make first parameter STRINGS const.
>> Hmmm... can already released public API be changed like that?
>> Stefan
> Hm, oh.
> * neels slaps himself
> We don't want a svn_cstring_join2(), do we?
> Instead, we could cast explicitly to remove the warnings from gstein's r34178.

Then bug Greg about it and let him fix it. :P

> But to me the committed fix feels right. svn_cstring_join() doesn't ever
> change that parameter. Does making the arg const even cause warnings in
> calling code? It doesn't, does it?

I seem to recall us changing the constness of existing function parameters
before, but I don't remember whether we were making them const or removing it.
I seem to think the latter, which feels better for API compatibility, but I
don't recall for certain.


Received on 2008-11-15 04:41:18 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.