Greg Stein wrote:
[...]
> [adding const]
> No need. This is a valid change. From a developer's standpoint, they
> can now pass either non-const (as before) or const arrays into
> svn_cstring_join(). We're *adding* capability, but not taking away (or
> making source incompatible) anything they had before. At a binary
> level, nothing has changed either. We're simply telling developers
> "hey, we won't change what you pass to us."
>
> Totally safe change.
>
> *Removing* const is a no-no, however.
>
[...]
>> I seem to recall us changing the constness of existing function parameters
>> before, but I don't remember whether we were making them const or removing it.
>> I seem to think the latter, which feels better for API compatibility, but I
>> don't recall for certain.
>
> Adding const is fine, removing is Bad.
Exactly, I was gonna say that.
Thanks for the review and clarifying things.
~Neels
Received on 2008-11-16 01:14:52 CET