Re: Minor nit with Makefile

C. Michael Pilato wrote:
> +1 to 'check' depending on 'all'.
>

Is this all that is required? Does that fall under the "obvious" rule?

> Index: Makefile.in
> ===================================================================
> --- Makefile.in (revision 31610)
> +++ Makefile.in (working copy)
> @@ -376,7 +376,7 @@
> # "make check CLEANUP=true" will clean up directories for successful tests.
> # "make check TESTS=subversion/tests/cmdline/basic_tests.py"
> # will perform only basic tests (likewise for other tests).
> -check: $(TEST_DEPS) @BDB_TEST_DEPS@
> +check: $(TEST_DEPS) @BDB_TEST_DEPS@ all
> @if test "$(PYTHON)" != "none"; then \
> flags="--verbose"; \
> if test "$(CLEANUP)" != ""; then \
>

John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-06 15:50:02 CEST