[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Minor nit with Makefile

From: John Peacock <john.peacock_at_havurah-software.org>
Date: Sat, 07 Jun 2008 19:39:06 -0400

John Peacock wrote:
> C. Michael Pilato wrote:
>> +1 to 'check' depending on 'all'.
> Is this all that is required? Does that fall under the "obvious" rule?

PING! I'd be happy to commit the below fragment to trunk (and nominate it for
1.5.x as obvious) if some full committer would give me an OK.


make check should depend on 'all' target for simplicity's sake

* Makefile.in
   add 'all' to check: target of top level Makefile


Index: Makefile.in
--- Makefile.in (revision 31610)
+++ Makefile.in (working copy)
@@ -376,7 +376,7 @@
  # "make check CLEANUP=true" will clean up directories for successful tests.
  # "make check TESTS=subversion/tests/cmdline/basic_tests.py"
  # will perform only basic tests (likewise for other tests).
+check: $(TEST_DEPS) @BDB_TEST_DEPS@ all
         @if test "$(PYTHON)" != "none"; then \
           flags="--verbose"; \
           if test "$(CLEANUP)" != ""; then \

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-08 01:37:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.