Re: Minor nit with Makefile

Well, I wonder if the right (as in, "most conservative") thing to do would be:

   check: bin $(TEST_DEPS) @BDB_TEST_DEPS@

(because 'bin' is the rule that builds 'svn', 'svnadmin', 'svnlook', etc.)

?

John Peacock wrote:
> C. Michael Pilato wrote:
>> +1 to 'check' depending on 'all'.
>>
>
> Is this all that is required? Does that fall under the "obvious" rule?
>
>> Index: Makefile.in
>> ===================================================================
>> --- Makefile.in (revision 31610)
>> +++ Makefile.in (working copy)
>> @@ -376,7 +376,7 @@
>> # "make check CLEANUP=true" will clean up directories for successful
>> tests.
>> # "make check TESTS=subversion/tests/cmdline/basic_tests.py"
>> # will perform only basic tests (likewise for other tests).
>> -check: $(TEST_DEPS) @BDB_TEST_DEPS@
>> +check: $(TEST_DEPS) @BDB_TEST_DEPS@ all
>> @if test "$(PYTHON)" != "none";
>> then \
>>
>> flags="--verbose"; \
>> if test "$(CLEANUP)" != "";
>> then \
>>
>
> John

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand