[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ruby bindings test failure on 1.5.x branch

From: Mark Phippard <markphip_at_gmail.com>
Date: Fri, 23 May 2008 10:51:41 -0400

On Fri, May 23, 2008 at 10:45 AM, Kouhei Sutou <kou_at_cozmixng.org> wrote:
>> I have reverse merged the 3 revisions Karl proposed and running all
>> tests. I get an error in Ruby tests but it looks unrelated to these
>> revisions.
>>
>> 1) Failure:
>> test_mkdir_p(SvnClientTest)
>> [/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/test_client.rb:241]:
>> <["/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/wc-tmp/wc/parent",
>> "/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/wc-tmp/wc/parent/child"]>
>> expected but was
>> <["test/wc-tmp/wc/parent", "test/wc-tmp/wc/parent/child"]>.
>>
>> 212 tests, 1439 assertions, 1 failures, 0 errors
>
> What about the attached patch?
>
> But I don't know about a need of notification API
> incompatibility between trunk and 1.5.x.

Do any of these trunk changes need to be backported (related to this problem?)

r31384 | kou | 2008-05-23 03:15:05 EDT
Changed paths:
        M /trunk/subversion/bindings/swig/ruby/svn/client.rb

Fix wrong argument name.

* subversion/bindings/swig/ruby/svn/client.rb
  (Svn::Client::Context#proplist): Swap rev and peg_rev.

----------------------------------------------------------------------------
r31355 | joeswatosh | 2008-05-22 10:17:01 EDT
Changed paths:
        M /trunk/subversion/bindings/swig/ruby/test/test_client.rb

Follow on to r31349 "Follow the current notify information behavior.
(Receive absolute path not relative path.)"

* subversion/bindings/swig/ruby/test/test_client.rb
  (SvnClientTest#test_move,SvnClientTest#test_move_force): Adjust test
   expectations.

----------------------------------------------------------------------------
r31350 | kou | 2008-05-22 08:23:52 EDT
Changed paths:
        M /trunk/subversion/bindings/swig/ruby/svn/client.rb
        M /trunk/subversion/bindings/swig/ruby/test/test_client.rb

Follow the current notify information behavior.
(Receive absolute path not relative path.)

* subversion/bindings/swig/ruby/test/test_client.rb
  (SvnClientTest#test_copy): Use absolute path to compare notified path.

* subversion/bindings/swig/ruby/svn/client.rb
  (Svn::Client::Contexet#copy): Remove a needless space.

----------------------------------------------------------------------------
r31349 | kou | 2008-05-22 07:29:37 EDT
Changed paths:
        M /trunk/subversion/bindings/swig/ruby/test/test_client.rb

Follow the current notify information behavior.
(Receive absolete path not relative path.)

* subversion/bindings/swig/ruby/test/test_client.rb
  (SvnClientTest#assert_mkdir_with_multiple_paths): New assertion.
  (SvnClientTest#test_mkdir_with_multiple_paths):
  - Rename from test_mkdir_multiple2.
  - Use assert_mkdir_with_multiple_paths.
  (SvnClientTest#test_mkdir_with_multiple_paths_as_array):
  - Rename from test_mkdir_multiple.
  - Use assert_mkdir_with_multiple_paths.

----------------------------------------------------------------------------

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-23 16:51:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.