Re: Ruby bindings test failure on 1.5.x branch

Hi,

In <ff892c5d0805230751n1177ecf9pe2a2cf089bf2c4a3_at_mail.gmail.com>
  "Re: Ruby bindings test failure on 1.5.x branch" on Fri, 23 May 2008 10:51:41 -0400,
  "Mark Phippard" <markphip_at_gmail.com> wrote:

> On Fri, May 23, 2008 at 10:45 AM, Kouhei Sutou <kou_at_cozmixng.org> wrote:
> >> I have reverse merged the 3 revisions Karl proposed and running all
> >> tests. I get an error in Ruby tests but it looks unrelated to these
> >> revisions.
> >>
> >> 1) Failure:
> >> test_mkdir_p(SvnClientTest)
> >> [/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/test_client.rb:241]:
> >> <["/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/wc-tmp/wc/parent",
> >> "/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/wc-tmp/wc/parent/child"]>
> >> expected but was
> >> <["test/wc-tmp/wc/parent", "test/wc-tmp/wc/parent/child"]>.
> >>
> >> 212 tests, 1439 assertions, 1 failures, 0 errors
> >
> > What about the attached patch?
> >
> > But I don't know about a need of notification API
> > incompatibility between trunk and 1.5.x.
>
> Do any of these trunk changes need to be backported (related to this problem?)

There is no change related to this problem. There is just a
change that fixes API improve. Others are for trunk specific
behavior.

> r31384 | kou | 2008-05-23 03:15:05 EDT
> Changed paths:
> M /trunk/subversion/bindings/swig/ruby/svn/client.rb
>
> Fix wrong argument name.
>
> * subversion/bindings/swig/ruby/svn/client.rb
> (Svn::Client::Context#proplist): Swap rev and peg_rev.

This change doesn't change any behaviors. It just guards
against user confusion from argument name. It may be better
to backport but not must.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org