[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Ruby bindings test failure on 1.5.x branch

From: Bert Huijben <bert_at_vmoo.com>
Date: Fri, 23 May 2008 17:33:14 +0200

> -----Original Message-----
> From: Mark Phippard [mailto:markphip_at_gmail.com]
> Sent: vrijdag 23 mei 2008 16:52
> To: Kouhei Sutou
> Cc: dev_at_subversion.tigris.org
> Subject: Re: Ruby bindings test failure on 1.5.x branch

> >> 1) Failure:
> >> test_mkdir_p(SvnClientTest)
> >> [/Users/mphippard/work/svn-
> 1.5.x/subversion/bindings/swig/ruby/test/test_client.rb:241]:
> >> <["/Users/mphippard/work/svn-
> 1.5.x/subversion/bindings/swig/ruby/test/wc-tmp/wc/parent",
> >> "/Users/mphippard/work/svn-
> 1.5.x/subversion/bindings/swig/ruby/test/wc-tmp/wc/parent/child"]>
> >> expected but was
> >> <["test/wc-tmp/wc/parent", "test/wc-tmp/wc/parent/child"]>.
> >>
> >> 212 tests, 1439 assertions, 1 failures, 0 errors
> >
> > What about the attached patch?
> >
> > But I don't know about a need of notification API
> > incompatibility between trunk and 1.5.x.

This test probably fails on the notification changes in r31211. Before that
revision the notify handler received commit paths which weren't valid in all
cases (not-relative and not-absolute and it must be one or the other to be
correct).

Starting in r31211 the handler receives the whole path and a path_prefix of
the commit root. (From those parts the old displayed path can be
calculated.. but that display path is not always valid)

See subversion/svn/notify.c for some example code on how to translate the
path.

(Summary: If path prefix is non-null and equals the start of path, then
strip prefix from path).

Note: r31211 is not backported to 1.5.x.

        Bert

>
> Do any of these trunk changes need to be backported (related to this
> problem?)
>
> r31384 | kou | 2008-05-23 03:15:05 EDT
> Changed paths:
> M /trunk/subversion/bindings/swig/ruby/svn/client.rb
>
> Fix wrong argument name.
>
> * subversion/bindings/swig/ruby/svn/client.rb
> (Svn::Client::Context#proplist): Swap rev and peg_rev.
>
> -----------------------------------------------------------------------
> -----
> r31355 | joeswatosh | 2008-05-22 10:17:01 EDT
> Changed paths:
> M /trunk/subversion/bindings/swig/ruby/test/test_client.rb
>
> Follow on to r31349 "Follow the current notify information behavior.
> (Receive absolute path not relative path.)"
>
> * subversion/bindings/swig/ruby/test/test_client.rb
> (SvnClientTest#test_move,SvnClientTest#test_move_force): Adjust test
> expectations.
>
> -----------------------------------------------------------------------
> -----
> r31350 | kou | 2008-05-22 08:23:52 EDT
> Changed paths:
> M /trunk/subversion/bindings/swig/ruby/svn/client.rb
> M /trunk/subversion/bindings/swig/ruby/test/test_client.rb
>
> Follow the current notify information behavior.
> (Receive absolute path not relative path.)
>
> * subversion/bindings/swig/ruby/test/test_client.rb
> (SvnClientTest#test_copy): Use absolute path to compare notified
> path.
>
> * subversion/bindings/swig/ruby/svn/client.rb
> (Svn::Client::Contexet#copy): Remove a needless space.
>
> -----------------------------------------------------------------------
> -----
> r31349 | kou | 2008-05-22 07:29:37 EDT
> Changed paths:
> M /trunk/subversion/bindings/swig/ruby/test/test_client.rb
>
> Follow the current notify information behavior.
> (Receive absolete path not relative path.)
>
> * subversion/bindings/swig/ruby/test/test_client.rb
> (SvnClientTest#assert_mkdir_with_multiple_paths): New assertion.
> (SvnClientTest#test_mkdir_with_multiple_paths):
> - Rename from test_mkdir_multiple2.
> - Use assert_mkdir_with_multiple_paths.
> (SvnClientTest#test_mkdir_with_multiple_paths_as_array):
> - Rename from test_mkdir_multiple.
> - Use assert_mkdir_with_multiple_paths.
>
> -----------------------------------------------------------------------
> -----
>
>
>
>
> --
> Thanks
>
> Mark Phippard
> http://markphip.blogspot.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-23 17:33:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.