[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ruby bindings test failure on 1.5.x branch

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: Fri, 23 May 2008 23:45:17 +0900 (JST)

Hi,

In <ff892c5d0805230732q48057e61oe980e8e97d756983_at_mail.gmail.com>
  "Ruby bindings test failure on 1.5.x branch" on Fri, 23 May 2008 10:32:05 -0400,
  "Mark Phippard" <markphip_at_gmail.com> wrote:

> I have reverse merged the 3 revisions Karl proposed and running all
> tests. I get an error in Ruby tests but it looks unrelated to these
> revisions.
>
> 1) Failure:
> test_mkdir_p(SvnClientTest)
> [/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/test_client.rb:241]:
> <["/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/wc-tmp/wc/parent",
> "/Users/mphippard/work/svn-1.5.x/subversion/bindings/swig/ruby/test/wc-tmp/wc/parent/child"]>
> expected but was
> <["test/wc-tmp/wc/parent", "test/wc-tmp/wc/parent/child"]>.
>
> 212 tests, 1439 assertions, 1 failures, 0 errors

What about the attached patch?

But I don't know about a need of notification API
incompatibility between trunk and 1.5.x.

Thanks,

--
kou

Index: subversion/bindings/swig/ruby/test/test_client.rb
===================================================================
--- subversion/bindings/swig/ruby/test/test_client.rb (revision 31388)
+++ subversion/bindings/swig/ruby/test/test_client.rb (working copy)
@@ -238,7 +238,7 @@
 
     infos.clear
     ctx.commit(@wc_path)
- assert_equal(full_paths.collect {|path| path.to_s}.sort,
+ assert_equal([dir_path, child_dir_path].collect {|path| path.to_s}.sort,
                  infos.collect{|path, notify| path}.sort)
     assert_equal([true, true],
                  infos.collect{|path, notify| notify.commit_added?})

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-23 16:45:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.