[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix wrong string in subversion/libsvn_repos/reporter.c

From: Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com>
Date: 2007-12-28 20:50:42 CET

2007-12-28 09:49:24 Karl Fogel napisał(a):
> Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com> writes:
> > This 'fmt' isn't necessary.
> > What do you think about this version?:
>
> I like the new version fine, thanks. To answer your other mail, the
> explanatory comment should go in the code, not the log message.
>
> -Karl
>
> > 2007-12-27 20:01:10 Arfrever Frehtes Taifersar Arahesis napisał(a):
> >> Index: subversion/libsvn_repos/reporter.c
> >> ===================================================================
> >> --- subversion/libsvn_repos/reporter.c (wersja 28655)
> >> +++ subversion/libsvn_repos/reporter.c (kopia robocza)
> >> @@ -165,8 +165,11 @@
> >> if (len + 1 < len)
> >> {
> >> return svn_error_createf(SVN_ERR_REPOS_BAD_REVISION_REPORT, NULL,
> >> - _("Invalid length (%" APR_UINT64_T_FMT ") "
> >> - "when about to read a string"), len);
> >> + apr_psprintf(pool,
> >> + _("Invalid length (%%%s) when "
> >> + "about to read a string"),
> >> + APR_UINT64_T_FMT),
> >> + len);
> >> }
> >>
> >> buf = apr_palloc(pool, len + 1);
> >>

Committed in r28692.

-- 
Arfrever Frehtes Taifersar Arahesis

Received on Fri Dec 28 20:54:18 2007

This is an archived mail posted to the Subversion Dev mailing list.