[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix wrong string in subversion/libsvn_repos/reporter.c

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-12-28 09:49:47 CET

Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com> writes:
> This 'fmt' isn't necessary.
> What do you think about this version?:

I like the new version fine, thanks. To answer your other mail, the
explanatory comment should go in the code, not the log message.

-Karl

> 2007-12-27 20:01:10 Arfrever Frehtes Taifersar Arahesis napisał(a):
>> Index: subversion/libsvn_repos/reporter.c
>> ===================================================================
>> --- subversion/libsvn_repos/reporter.c (wersja 28655)
>> +++ subversion/libsvn_repos/reporter.c (kopia robocza)
>> @@ -165,8 +165,11 @@
>> if (len + 1 < len)
>> {
>> return svn_error_createf(SVN_ERR_REPOS_BAD_REVISION_REPORT, NULL,
>> - _("Invalid length (%" APR_UINT64_T_FMT ") "
>> - "when about to read a string"), len);
>> + apr_psprintf(pool,
>> + _("Invalid length (%%%s) when "
>> + "about to read a string"),
>> + APR_UINT64_T_FMT),
>> + len);
>> }
>>
>> buf = apr_palloc(pool, len + 1);
>>
>
>
> --
> Arfrever Frehtes Taifersar Arahesis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 28 07:49:40 2007

This is an archived mail posted to the Subversion Dev mailing list.