[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

validate_eol_prop_against_file() inefficiency?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-12-28 19:13:24 CET

While updating the svnbook, I noticed something odd. In Subversion 1.4,
when you try to set svn:eol-style on a binary file, you get the obvious error:

   % svn pset svn:eol-style CRLF suse.png
   svn: File 'suse.png' has binary mime type property

In trunk, however, you get something far more bizarre:

   % svn pset svn:eol-style CRLF suse.png
   subversion/libsvn_wc/props.c:2425: (apr_err=200009)
   svn: File 'suse.png' has inconsistent newlines
   subversion/libsvn_subr/subst.c:736: (apr_err=135000)
   svn: Inconsistent line ending style

I see that libsvn_wc/props.c:validate_eol_prop_against_file() has been
ordered differently in trunk. What I can't figure out is why the
far-more-expensive newline consistency check was moved ahead of the
super-cheap is-binary check? Besides being really inefficient, the new
error is just not as clear.

Was this fallout from the URL propsetting support or something?

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Fri Dec 28 19:26:37 2007

This is an archived mail posted to the Subversion Dev mailing list.