Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

On 7/1/07, Ivan Zhakov <chemodax@gmail.com> wrote:
[snip]
> It's strange, because it works for me: VS2005, fsfs.

Hmm, yes, strange -- VS2005 works for me too. I'll try to debug
through the fs-test failures on VC6 to see what's going on when I
can.

>
> Btw, what do you think about patch itself?
>

As you and Stefan said, using the API rather than the registry will
probably be more robust and I think the win32 specific stuff might be
better off in its own file.

I don't have any strong feelings about the temporary memory
management, but I would tend to prefer a subpool, I think, unless it
turns out to be a performance issue as Stefan thinks it might.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 1 15:06:00 2007