[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-07-03 18:58:00 CEST

On Sun, 01 Jul 2007, D.J. Heap wrote:

> On 7/1/07, Ivan Zhakov <chemodax@gmail.com> wrote:
...
> >Btw, what do you think about patch itself?
>
> As you and Stefan said, using the API rather than the registry will
> probably be more robust and I think the win32 specific stuff might be
> better off in its own file.

Just a nitpick, but some of the formatting is pretty inconsistent with
the rest of the code base (use of Hungarian notation, lack of
whitespace between data type and value in type casts, etc.).

> I don't have any strong feelings about the temporary memory
> management, but I would tend to prefer a subpool, I think, unless it
> turns out to be a performance issue as Stefan thinks it might.

Is this question in relation to svn_subr__win32_xlate_to_stringbuf()?

  • application/pgp-signature attachment: stored
Received on Tue Jul 3 18:57:48 2007

This is an archived mail posted to the Subversion Dev mailing list.