[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25447 - trunk/subversion/tests/cmdline/svntest

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-07-01 14:44:37 CEST

Vlad Georgescu wrote:
> lgo@tigris.org wrote:
>
>> Log:
>> Fix issue where failed tests on Windows don't return errorlevel > 0.
>>
>> * subversion/tests/cmdline/svntest/main.py
>> (SpawnTest.run): the exitcode of a spawned process on Windows will not be
>> correct, so check for patterns of type 'FAIL: ' on stdout of the process.
>>
>> Modified:
>> trunk/subversion/tests/cmdline/svntest/main.py
>>
>> Modified: trunk/subversion/tests/cmdline/svntest/main.py
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/svntest/main.py?pathrev=25447&r1=25446&r2=25447
>> ==============================================================================
>> --- trunk/subversion/tests/cmdline/svntest/main.py (original)
>> +++ trunk/subversion/tests/cmdline/svntest/main.py Mon Jun 18 11:55:24 2007
>> @@ -806,8 +806,11 @@
>>
>> self.result, self.stdout_lines, self.stderr_lines =\
>> spawn_process(command, 1, None, *args)
>> - sys.stdout.write('.')
>> + # don't trust the exitcode, will not be correct on Windows
>> + if filter(lambda x: x[:6] == 'FAIL: ', self.stdout_lines):
>> + self.result = 1
>> self.tests.append(self)
>> + sys.stdout.write('.')
>>
>
> Shouldn't we also check for 'XPASS: ' here?
>
Yes we do. Fixed in r25599.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 1 14:40:47 2007

This is an archived mail posted to the Subversion Dev mailing list.