[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Destroy the APR subpool before every successful returnstatement

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2007-01-08 18:49:11 CET

On Mon, 2007-01-08 at 13:36 +0100, Erik Huelsmann wrote:
> ... yes, except that these functions don't get a pool passed in: they
> create a subpool inside a pool which they get in through a baton. At
> the end, they need to destroy the subpool, because if they don't,
> pools will be created iteratively.

Ah, good catch.

Yes, the functions need to clear the subpool in all non-error cases, and
(if I haven't missed something about it) the patch should be applied.

The callback signatures should also, in theory, be modified to take a
pool (we recognized some time ago that baton pools are not a good
substitute for argument pools). But if that requires making an API
change it may not be worth the pain.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 8 18:48:21 2007

This is an archived mail posted to the Subversion Dev mailing list.