[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Destroy the APR subpool before every successful returnstatement

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-08 19:58:28 CET

On Mon, 08 Jan 2007, Greg Hudson wrote:

> On Mon, 2007-01-08 at 13:36 +0100, Erik Huelsmann wrote:
> > ... yes, except that these functions don't get a pool passed in: they
> > create a subpool inside a pool which they get in through a baton. At
> > the end, they need to destroy the subpool, because if they don't,
> > pools will be created iteratively.
>
> Ah, good catch.
>
> Yes, the functions need to clear the subpool in all non-error cases, and
> (if I haven't missed something about it) the patch should be applied.

+1

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 8 19:58:03 2007

This is an archived mail posted to the Subversion Dev mailing list.