[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Enable error lifetime checking by default in maintainer mode

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-08 19:25:07 CET

On Sun, 07 Jan 2007, Malcolm Rowe wrote:
...
> [[[
> Enable error lifetime checking by default in maintainer mode, causing
> processes to abort when terminating if any error objects have been
> unhandled.
>
> * subversion/libsvn_subr/error.c
> (err_abort, make_error_internal, svn_error_compose, svn_error_dup,
> svn_error_clear): Change code sections guarded by SVN_DEBUG_ERROR to
> use SVN_DEBUG instead.
> ]]]
>
> Regards,
> Malcolm

> Index: subversion/libsvn_subr/error.c
> ===================================================================
> --- subversion/libsvn_subr/error.c (revision 22915)
> +++ subversion/libsvn_subr/error.c (working copy)
> @@ -61,7 +61,7 @@ svn_error__locate(const char *file, long
>
> /* Cleanup function for errors. svn_error_clear () removes this so
> errors that are properly handled *don't* hit this code. */
> -#if defined(SVN_DEBUG_ERROR)
> +#if defined(SVN_DEBUG)
...

I'm in favor of this change. Alternately, SVN_DEBUG_ERROR could be
defined when SVN_DEBUG is defined. This is only slightly more
complex, but does leave in a convenient toggle for people who need
more control over things.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 8 19:24:44 2007

This is an archived mail posted to the Subversion Dev mailing list.