Re: svn commit: r20246 - trunk/subversion/tests/cmdline/svntest

On Mon, 26 Jun 2006 15:45:11 +0530, Malcolm Rowe
<malcolm-svn-dev@farside.org.uk> wrote:

> On Mon, Jun 26, 2006 at 03:43:23PM +0530, Madan U Sreenivasan wrote:
>> >+# calculate repo url from pristine_dir
>> >+pristine_url = test_area_url + '/' + pristine_dir
>> >+if windows == 1:
>> >+ pristine_url = string.replace(pristine_url, '\\', '/')
>>
>> why not os.path.join() here?
>>
>
> Looks like it's building a URL (which always has forward slashes),
> not a path (which would contain backslashes on Windows). How would
> os.path.join help?

hmmmm, you are right. I was stuck at why the pristine_url replacement is
happening.

But anyways, I think we should do the pristine_url backslash replacement
part before we prepend the test_area_url. Like:

>> >+if windows == 1:
>> >+ pristine_url = string.replace(pristine_url, '\\', '/')
>> >+# calculate repo url from pristine_dir
>> >+pristine_url = test_area_url + '/' + pristine_dir

[snip]

> PS. Please don't cc: the svn@ list - that's for commit emails only.

oh, sorry. I must have missed that.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 26 12:45:05 2006