[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add some RDoc comments to the SWIG/Ruby bindings, part 1

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-06-26 13:13:02 CEST

Hi,

In <20060625.205530.59484642.nori1@dolphin.c.u-tokyo.ac.jp>
  "Re: [PATCH] Add some RDoc comments to the SWIG/Ruby bindings, part 1" on Sun, 25 Jun 2006 20:55:30 +0900 (JST),
  Kobayashi Noritada <nori1@dolphin.c.u-tokyo.ac.jp> wrote:

> Hi,
>
> > > + # Following methods are also available:
> > > + #
> > > + # [created_rev]
> > > + # Returns a revision at which the instance was last modified.
> > > + # [has_props]
> > > + # Returns true if the instance has properties.
> > > + # [last_author]
> > > + # Returns an author who last modified the instance.
> > > + # [size]
> > > + # Returns a size of the instance.
> > > class Dirent
> >
> > We should provide have_props? method instead of has_props to make
> > the bindings more Rubyish. Could you add a new alias and update
> > the corresponded commet after you commit?
>
> All right, here is a patch to do so. It also provides tests for that
> method. Could you please review it?

+1.
It looks good. Please commit but I have a request.

> Index: subversion/bindings/swig/ruby/svn/core.rb
> ===================================================================
> --- subversion/bindings/swig/ruby/svn/core.rb (revision 20239)
> +++ subversion/bindings/swig/ruby/svn/core.rb (working copy)

> @@ -356,6 +356,8 @@
> __time = _time
> __time && Time.from_apr_time(__time)
> end
> +
> + alias have_props? has_props
> end

I want to place such aliases(*) to just under class
statement. Such aliases are convenience aliases that don't
have their definition in the target class. In
Svn::Client::PropListItem case, I placed name and props
aliases to just under 'class PropListItem':

  class PropListItem
    alias name node_name
    alias props prop_hash

Could you please change 'alias have_props? has_props' place,
nori?

Regards,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 26 13:13:39 2006

This is an archived mail posted to the Subversion Dev mailing list.