Re: svn commit: r20246 - trunk/subversion/tests/cmdline/svntest

On Mon, Jun 26, 2006 at 03:43:23PM +0530, Madan U Sreenivasan wrote:
> >+# calculate repo url from pristine_dir
> >+pristine_url = test_area_url + '/' + pristine_dir
> >+if windows == 1:
> >+ pristine_url = string.replace(pristine_url, '\\', '/')
>
> why not os.path.join() here?
>

Looks like it's building a URL (which always has forward slashes),
not a path (which would contain backslashes on Windows). How would
os.path.join help?

Regards,
Malcolm

PS. Please don't cc: the svn@ list - that's for commit emails only.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 26 12:15:52 2006