Re: svn commit: r20246 - trunk/subversion/tests/cmdline/svntest

Quoting Madan U Sreenivasan <madan@collab.net>:
..
> But anyways, I think we should do the pristine_url backslash replacement
> part before we prepend the test_area_url. Like:
>
> >> >+if windows == 1:
> >> >+ pristine_url = string.replace(pristine_url, '\\', '/')
> >> >+# calculate repo url from pristine_dir
> >> >+pristine_url = test_area_url + '/' + pristine_dir

Madan,

I just copied the code from its original location, didn't do any refactoring.
Frankly, while your remark makes the code cleaner, I don't care enough to
change it myself. But I'll support (or commit if needed) your patch.

thanks for the review,

Lieven.

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 26 18:00:42 2006