[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch newline in log messages

From: <kfogel_at_collab.net>
Date: 2006-03-02 01:42:52 CET

Vincent Lefevre <vincent+svn@vinc17.org> writes:
> But is it important to recover the original log data? I don't think
> it is. The server should do some form of normalization (I prefer this
> term to "munging"), IMHO.
>
> For instance, one could decide that the number of ending newline
> characters must be fixed (choose either 0 or 1). I don't think it
> makes sense to have a variable number of newline characters (when
> this happens, it happens by accident).
>
> Also, is the EOL for log messages always \n on the server, or does it
> depend on the platform of the client that submitted the log message?
> IMHO, it should always be \n (so that it can be correctly converted
> on the client side when displaying the log). But if such a conversion
> occurs, this is "munging" too. :)

Fair enough -- yes, we already "munge" / "normalize" log data anyway,
though I believe it's the client that does it, not the server.

(However, I still think I like the hook solution better. Less work
for us to maintain, all the code in one place for inspection, etc.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 2 03:28:28 2006

This is an archived mail posted to the Subversion Dev mailing list.