[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PROPOSAL] enforce log messages as series of lines

From: Vincent Lefevre <vincent+svn_at_vinc17.org>
Date: 2006-03-02 03:39:32 CET

On 2006-03-01 14:46:08 -0800, Justin Erenkrantz wrote:
> -1 (vote, not veto). Two principal reasons:
>
> - We should never silently munge the user's UTF-8 commit message
> (such as adding or removing newlines). We should do our best to
> respect the log as provided to us.

I disagree with you. Otherwise svn should be modified so that
"svn ci -m '...'" and "svn ci" with the log message entered in an
editor should behave in a consistent manner, taking into account
that the string after the -m doesn't normally contain a newline,
and in an editor, the user can't remove the newline before the
line "--This line, and those below, will be ignored--".

The user mustn't be forced to use a hook to avoid an inconsistency
that svn introduced.

But IMHO, a normalization of the log file makes sense. After all,
there's already charset conversion to UTF-8 (and EOL conversion?).

> - We should never silently retroactively 'reformat' historical log
> messages.

Why not, but unless the chosen format would produce garbage (e.g. a
format without an additional newline). In such a case (no reformat),
then a tool (based on "svnadmin setlog"?) should be supplied so that
the user can easily reformat all the old logs if he wishes.

-- 
Vincent Lefèvre <vincent_at_vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / SPACES project at LORIA
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 2 03:40:15 2006

This is an archived mail posted to the Subversion Dev mailing list.