[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch newline in log messages

From: Alan Barrett <apb_at_cequrux.com>
Date: 2006-03-01 17:57:17 CET

On Tue, 28 Feb 2006, kfogel@collab.net wrote:
> On the other hand, I do favor enforcing the format of log messages on
> the repository side instead (an idea first proposed by Greg Hudson, if
> I remember correctly). In other words, on the repository side we'd do
> the same thing: ensure there's always exactly one trailng newline on
> the log message. This also munges the user's data, in the same way.
> It would fix legacy svn:log properties too as necessary.

Yes, please. I find it surprising that

        svn commit -m "message"

does not behave like

        echo "message" >messagefile
        svn commit -F messagefile

or

        svn commit
        [type "message" as the only line above the "this line will be
        removed" marker]

I'd call it a bug that "svn commit -m" fails to append a newline to the
message. (CVS handles this correctly, by adding a newline to messages
that do not already end with a newline, and not adding a newline to
messages that already end with a newline.)

> The server-side solution has the advantage of solving the problem for
> all clients. I think I'd be +1 on your patch, as a compatibility
> measure for older repositories, *if* we also implemented this behavior
> on the server side. But doing only the client change seems wrong: log
> messages are repository data, they should be in the correct format
> when they are stored/retrieved in the repository.
>
> Thoughts?

I believe that enforcement of a log message as a sequence of lines
should be done on the server side.

--apb (Alan Barrett)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 1 18:06:31 2006

This is an archived mail posted to the Subversion Dev mailing list.