[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18218 - in trunk: . subversion/libsvn_ra_serf

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2006-01-25 18:32:05 CET

On 1/25/06, Justin Erenkrantz <justin@erenkrantz.com> wrote:

> > Space before paren. Applies to more places.
>
> That's one I definitely won't follow as it is optional. =)
>
> (The GNU coding style is *awful* to read! But, I've said that for years here.)

Historical precedent says that since you created the file/module, so
you're free to choose your formatting style, as long as its internally
consistent. (libsvn_ra_svn and mod_dav_svn have their own formatting
conventions, after all.)

But that's just about formatting. Regarding the use of svn_boolean_t:
 that's about making the code itself "subversion-y". I would argue
that since this is a genuine subversion module, there's still an
obligation to make use of subversion datastructures, types, and APIs
whereever possible. This isn't an apache module. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 18:59:33 2006

This is an archived mail posted to the Subversion Dev mailing list.