[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18218 - in trunk: . subversion/libsvn_ra_serf

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2006-01-25 17:58:27 CET

On 1/25/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> Indentation.

Sorry. I hate 2 space indents - I'll try to remember in the future. =)

> Why not use svn_boolean_t?

An int is svn_boolean_t. =)

> Are you going to document this struct in a
> later commit?

When I complete SSL support, yes.

> > +} serf_session_t;
> > +
> > +static serf_bucket_t *
> > +conn_setup(apr_socket_t *sock,
> > + void *baton,
> > + apr_pool_t *pool)
>
> Space before paren. Applies to more places.

That's one I definitely won't follow as it is optional. =)

(The GNU coding style is *awful* to read! But, I've said that for years here.)

> Hmmm, one-letter names often lead to confusion. We use "b" for "baton" in
> many places. What about using a name like "bucket"?

Sure. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 18:14:23 2006

This is an archived mail posted to the Subversion Dev mailing list.