[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18218 - in trunk: . subversion/libsvn_ra_serf

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-01-25 22:44:45 CET

On Wed, 25 Jan 2006, Ben Collins-Sussman wrote:

> On 1/25/06, Justin Erenkrantz <justin@erenkrantz.com> wrote:
>
> > > Space before paren. Applies to more places.
> >
> > That's one I definitely won't follow as it is optional. =)
> >
> > (The GNU coding style is *awful* to read! But, I've said that for years here.)
>
> Historical precedent says that since you created the file/module, so
> you're free to choose your formatting style, as long as its internally
> consistent. (libsvn_ra_svn and mod_dav_svn have their own formatting
> conventions, after all.)
>
And since the file was already created with spaces... So it was getting
inconsitent.

Then we can discuss which style to choose. I would prefer the style with
spaces before parens to be used, *not* because of personal preference of
style, but because this is what most of our code uses. I'd like to go
*towards* consistency, not the oposite. To me, it is really frustrating
to work on or review a patch trying to be consistent inside each file when
the patch spans files with both styles.

I won't go on pushing this issue, because we can spend our lifes on more
useful stuff than style discussions and I guess this debate has been up
before. I just want to point out that anyones personal preference is
rather irrelevant here. My motivation is maintainability.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 22:45:35 2006

This is an archived mail posted to the Subversion Dev mailing list.