[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18218 - in trunk: . subversion/libsvn_ra_serf

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-01-25 14:38:55 CET

On Wed, 25 Jan 2006 jerenkrantz@tigris.org wrote:

> Modified: trunk/subversion/libsvn_ra_serf/serf.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_ra_serf/serf.c?rev=18218&p1=trunk/subversion/libsvn_ra_serf/serf.c&p2=trunk/subversion/libsvn_ra_serf/serf.c&r1=18217&r2=18218
> ==============================================================================
> --- trunk/subversion/libsvn_ra_serf/serf.c (original)
> +++ trunk/subversion/libsvn_ra_serf/serf.c Wed Jan 25 00:03:43 2006
> @@ -18,6 +18,8 @@
>
>
>
> +#include <apr_uri.h>
> +
> #include <serf.h>
>
> #include "svn_pools.h"
> @@ -55,6 +57,47 @@
> return serf_ssl;
> }
>
> +typedef struct {
> + apr_pool_t *pool;
> + serf_bucket_alloc_t *bkt_alloc;
> +
Indentation.

> + serf_context_t *context;
> + serf_ssl_context_t *ssl_context;
> +
> + serf_connection_t *conn;
> +
> + /* 0 or 1 */
> + int using_ssl;

Why not use svn_boolean_t? Are you going to document this struct in a
later commit?
> +} serf_session_t;
> +
> +static serf_bucket_t *
> +conn_setup(apr_socket_t *sock,
> + void *baton,
> + apr_pool_t *pool)

Space before paren. Applies to more places.

> +{
> + serf_bucket_t *b;

Hmmm, one-letter names often lead to confusion. We use "b" for "baton" in
many places. What about using a name like "bucket"?

I know that this is initial and experimental code, so it might feel early
for these stylistic comments. If you're planning (and promising) to go
through and fix all style issues last, just tell me:-)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 14:40:04 2006

This is an archived mail posted to the Subversion Dev mailing list.