[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] improve logging of errors under mod_dav_svn

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-01-23 23:20:44 CET

So while debugging a DAV problem recently I noticed that mod_dav_svn
isn't all that good about logging errors. Specifically,
dav_svn_convert_error has this way of taking the top error in a chain,
logging it, and forgetting about all the rest of the underlying
errors. This is kind of silly, since the mod_dav error infrastructure
actually has the same kind of chain of errors functionality that we
have in our svn_error_t stuff.

This is issue #2482, for the curious.

Anyway, I took a look at this today, and came up with a patch to fix
it. It just builds up a chain of DAV errors to correspond to the
chain of svn errors that are passed to dav_svn_convert_error. If
someone with some DAV background could take a look at it, I'd
appreciate it.

-garrett

[[[
Make mod_dav_svn log all the errors in a given chain, rather than just the
topmost one. This fixes issue #2482.

* subversion/mod_dav_svn/util.c
  (dav_svn_convert_error): Use build_error_chain to create our dav error.
  (build_error_chain): New helper function that recursively builds a chain
   of dav_error objects based on a svn_error_t.
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Jan 23 23:21:21 2006

This is an archived mail posted to the Subversion Dev mailing list.