[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] improve logging of errors under mod_dav_svn

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-01-24 23:44:19 CET

On 1/23/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> So while debugging a DAV problem recently I noticed that mod_dav_svn
> isn't all that good about logging errors. Specifically,
> dav_svn_convert_error has this way of taking the top error in a chain,
> logging it, and forgetting about all the rest of the underlying
> errors. This is kind of silly, since the mod_dav error infrastructure
> actually has the same kind of chain of errors functionality that we
> have in our svn_error_t stuff.
>
> This is issue #2482, for the curious.
>
> Anyway, I took a look at this today, and came up with a patch to fix
> it. It just builds up a chain of DAV errors to correspond to the
> chain of svn errors that are passed to dav_svn_convert_error. If
> someone with some DAV background could take a look at it, I'd
> appreciate it.

A slightly modified version of this (thanks to dlr's review) was
committed in r18211.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 24 23:44:40 2006

This is an archived mail posted to the Subversion Dev mailing list.