[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] dav_svn_get_repo_name handling of SVNParentPath

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-01-17 18:58:57 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Maxime Petazzoni wrote:
> * Daniel Rall <dlr@collab.net> [2006-01-14 13:06:06]:
>> Some of the function decls in this header file are marked up for
>> Doxygen. If we're running Doxygen on this header file, this func
>> could also use some markup. Also parameter and @since doucmentation.

Naughty dlr, for giving trick advice! :-)

We are _not_ running doxygen on this header, so there should be no @foo
markup. The only standard we have in non-doxygen comments is to use
ALL_UPPERCASE for function parameter names, to make them stand out.

> Based on your comments, here comes a new patch for the repository name
> issue. Same commit log.

[[[
Make mod_dav_svn retrieve a repository name even when configured to
operate with SVNParentPath.

* subversion/mod_dav_svn/mod_dav_svn.c
  (dav_svn_get_repo_name2): New function, revved from
    dav_svn_get_repo_name. Takes new root_path and repo_name arguments
    and returns a dav_error for error propagation. Retrieves the
    repository name in a SVNParentPath setup using dav_svn_split_uri.
  (dav_svn_get_repo_name): Deprecate.

* subversion/mod_dav_svn/dav_svn.h
  (dav_svn_get_repo_name2): Declare the new function in the API.

* subversion/mod_dav_svn/repos.c
  (dav_svn_get_resource): Use dav_svn_get_repo_name2 to retrieve the
  repository name, and propagate any dav_error values received.
]]]

Regarding deprecation:

We have never installed the dav_svn.h header file, whilst we do install
the mod_dav_svn.h header file located in subversion/include/ - to me
this indicates that the functions declared within dav_svn.h are
unequivocally private to the subversion source tree, and realistically
totally private to mod_dav_svn itself.
Therefore my opinion is that no api revving need take place.
(And that pretty much the entire contents of dav_svn.h ought to be using
double-underscore names.)

Max.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFDzTBhfFNSmcDyxYARAjd9AKDTlFE6vkHRwYaECTJllkaLfnUlYwCeIqrI
wMtyvPUGrmvSCGgHo9vs+eo=
=EU2O
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 17 22:14:25 2006

This is an archived mail posted to the Subversion Dev mailing list.