Re: svn 1.3.0: post-commit hook waits even if tasks are backgrounded

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> Any objections to commit this patch and propose it for 1.3 backport?

It's certainly an improvement so +1.

Looking at the hook code raises another question. When the post
commit code calls run_hook_cmd() it passes NULL for stdin_handle and
that causes the hook process to inherit stdin from calling process.
Is that sensible or should run_hook_cmd() substitute the null_handle
when stdin_handle is NULL? The doc string states:

   If STDIN_HANDLE is non-null, pass it as the hook's stdin, else pass
   no stdin to the hook. */

but it's not clear to me what "no stdin" means.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org