[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] dav_svn_get_repo_name handling of SVNParentPath

From: Maxime Petazzoni <maxime.petazzoni_at_bulix.org>
Date: 2006-01-14 23:30:32 CET

Hi,

* Daniel Rall <dlr@collab.net> [2006-01-14 13:06:06]:

> > > const char *dav_svn_get_repo_name(request_rec *r)
>
> Why not refactor this function to call dav_svn_get_repo_name2()?
>
> > > + const char *fs_parent_path;
> > > + const char *repos_name;
> > > + const char *ignored_path_in_repos;
> > > + const char *ignored_cleaned_uri;
> > > + const char *ignored_relative;
>
> Many of these parameters can be scoped to inside the
> "if (fs_parent_path != NULL)" block below.
>
> > > /* Return a descriptive name for the repository */
> > > const char *dav_svn_get_repo_name(request_rec *r);
> > > +dav_error *dav_svn_get_repo_name2(request_rec *r, const char *root_path,
> > > + char **repo_name);
> ...
>
> Some of the function decls in this header file are marked up for
> Doxygen. If we're running Doxygen on this header file, this func
> could also use some markup. Also parameter and @since doucmentation.

Based on your comments, here comes a new patch for the repository name
issue. Same commit log.

Thanks for the advices,
- Maxime

-- 
Maxime Petazzoni (http://www.bulix.org)
 -- gone crazy, back soon. leave message.

Received on Sat Jan 14 23:31:34 2006

This is an archived mail posted to the Subversion Dev mailing list.