[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix crash when copying added files with --force

From: Jim Blandy <jimb_at_red-bean.com>
Date: 2006-01-05 23:04:47 CET

On 1/5/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
> When copying added (but not committed yet) files with the --force flag,
> Subversion crashes in libsvn_wc/copy.c, line 515.
> That's because there are (IMHO) bogus brackets in the check there.
>
> Attached is a patch which fixes this issue.
> @@ -511,7 +511,7 @@
> _("'%s' is not under version control"),
> svn_path_local_style (src_path, pool));
>
> - if ((src_entry->repos != NULL && dst_entry->repos != NULL) &&
> + if (src_entry->repos != NULL && dst_entry->repos != NULL &&
> strcmp (src_entry->repos, dst_entry->repos) != 0)
> return svn_error_createf
> (SVN_ERR_WC_INVALID_SCHEDULE, NULL,

Huh? How can removing brackets around a sub-portion of an and-chain
have any effect? The && operator has lower precedence than !=,
function calls, and ->.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 6 00:06:48 2006

This is an archived mail posted to the Subversion Dev mailing list.