[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17984 - trunk/subversion/libsvn_ra_dav

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-01-05 22:43:40 CET

On 05 Jan 2006 07:50:00 -0600, kfogel@collab.net <kfogel@collab.net> wrote:

> This issue wasn't really introduced by this commit, I just happened to
> notice it as a result of reviewing this commit:
>
> The documentation for 'struct copy_baton' doesn't really talk about
> what its fields mean when they're NULL. Right now, it says:
>
> /* Context for parsing <D:error> bodies, used when we call ne_copy(). */
> struct copy_baton
> {
> /* The method neon is about to execute. */
> const char *method;
>
> /* A parser for handling <D:error> responses from mod_dav_svn. */
> ne_xml_parser *error_parser;
>
> /* If <D:error> is returned, here's where the parsed result goes. */
> svn_error_t *err;
>
> /* A place for allocating fields in this structure. */
> apr_pool_t *pool;
> };
>
> But when the baton is initialized above, the first three fields will
> be NULL. What would be a good description of the semantics of that?

NULL seems to indicate that we didn't hit a copy (for the "method"
field), or that we didn't hit an error (for the other two). I'll try
and come up with a useful description and add it.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 5 23:36:58 2006

This is an archived mail posted to the Subversion Dev mailing list.