[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix crash when copying added files with --force

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-01-05 23:18:00 CET

Stefan Küng <tortoisesvn@gmail.com> writes:

> When copying added (but not committed yet) files with the --force
> flag, Subversion crashes in libsvn_wc/copy.c, line 515.

Which --force flag exactly?

> That's because there are (IMHO) bogus brackets in the check there.
>
> Attached is a patch which fixes this issue.

> - if ((src_entry->repos != NULL && dst_entry->repos != NULL) &&
> + if (src_entry->repos != NULL && dst_entry->repos != NULL &&
> strcmp (src_entry->repos, dst_entry->repos) != 0)

That won't fix a crash, those brackets are redundant.

> return svn_error_createf
> (SVN_ERR_WC_INVALID_SCHEDULE, NULL,

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 6 00:11:03 2006

This is an archived mail posted to the Subversion Dev mailing list.