[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix tests for VS2005

From: D.J. Heap <djheap_at_gmail.com>
Date: 2005-12-03 16:07:00 CET

> > I don't see a need to do anything more (such as expand wildcards
> > ourselves on Win32 or change the property-present-character from * to
> > something else) because it only affects passing * or ? in as a
> > property value and is easy to workaround using the -F option...
> >
>
> I take it that this (VS2005) change also breaks setting the svn:executable
> (etc) properties like this (because they have a canonical value of '*')?
>
> Is there any reason we can't distribute and compile against the VS2003
> version of setargv.obj when we're compiling with VS2005?
>
> Regards,
> Malcolm

For our Win32 distribution Brane uses VC6, I believe, so it won't
affect that for now. If we switch to use VS2005 and really want to
preserve the previous releases wildcard-quoting, then we'll have to do
something else (like link the old version's setargv.obj or change the
VS2005 source for setargv or code wildcard expansion ourselves). Due
to the rather small impact (only affects setting property values with
wildcards in them) and easy workaround (-F), I don't think it's worth
it personally. I'm not sure how this falls in our compatibility
policies -- it's sort of (but not really on Win32) a shell thing.

svn:executable doesn't do anything on Win32, so that specific property
is not much of an issue (and some of the present/not present
properties like svn:executable get changed to * no matter what you try
to set their value to). And you can still use the -F option to set
them to *.

I did fiddle with trying to link with VS2003's setargv.obj and even
customzing the VS2005 setargv.obj source a bit, but tweaking the tests
was significantly easier and doesn't make the user fiddle with
anything to get all the tests to pass.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 3 16:07:56 2005

This is an archived mail posted to the Subversion Dev mailing list.